method's names
Vlad Skvortsov
vss at 73rus.com
Mon Nov 6 14:44:35 PST 2006
Oleg G. Sharov wrote:
>I have reviewed code of new classes (Database, WorkingCopy, LocalModsArea)
>Vlad, Why didn't you use verbs in some method's names?
>LocalModsArea.comments
>LocalModsArea.issues
>
>I prefer such names
>LocalModsArea.get_comments
>LocalModsArea.get_issues
>
>May be you should change names. What do you think?
>
>
These methods are the need of iteration over issues/comments and so a
construct like this:
for name, issue in db.issues():
do something
is read more like natural English and is also more "pythonic" (compare:
for x in dict.keys() / dict.values() / ...).
Makes sense?
--
Vlad Skvortsov, vss at 73rus.com, http://vss.73rus.com
More information about the Dev
mailing list