[ditrack commit] r1486 - in src/trunk: . DITrack DITrack/Command DITrack/Util DITrack/dt

[Ivan Glushkov]

On 4/9/07, Vlad Skvortsov <vss at 73rus.com> wrote:
> Hi!
>
> I'm sure this commit does what it needed, but I have a few concerns
> about it. First, as I've said earlier, I'm not in favor of idea of
> mixing environment variables with DITrack-specific variables. Thus my
> suggestion is to have clear distinction (by means of syntax) between them:
>
> $VAR == environment variable
> $DT:VAR == DITrack-specific variable (that *may* happen to have the same
> value as an environment variable).

I did almost the same, except for the '$'-sign in the beginning of the
ditrack-specific variables:

+class DTTemplate(string.Template):
+    delimiter = 'DT:'

> I also don't feel too comfortable with some of the design decisions
> here. My comments follow.
i'll review my changes.