several questions about your commits from branches/attachments.

Ivan Glushkov gli.work at gmail.com
Sat Aug 4 02:40:10 PDT 2007


Hi.

1. From Issue.py:
             for a in self.attachment_delta[0]:
                 assert a.name not in attachments
                 attachments.add_object(a)

             for a in self.attachment_delta[1]:
                 assert a.name in attachments
                 attachments.remove_object(a)


May be we should better use not an array, but a hash  
attachmetn_delta["add"],attachment_delta["rm"]?

2. act.py:
             elif r == mi_new:
                 ti = DITrack.UI.TextInput("File to attach (blank to  
abort)")

                 while 1:
                     fname = ti.run()

...
                         issue.add_attachment(fname)


It is possible to define a key for attachment in _Attachments:add(), but  
it's not allowed to determine it here.


3. May be we should use some agreement about attachments naming? For  
example to link to the second attachment of the 5'th issue: "i#5.f2"? Or  
something similar?

4. i might ask this too early and you've done it already, but:
    It would be very handy to see such output after 'acting' on issue:
	"File %s was attached as i#%d.f%d"  (using the agreement in previous  
suggestion)


Ivan.


More information about the Dev mailing list