[ditrack commit] r1893 - src/trunk/DITrack/Command

[Vlad Skvortsov]

gli at ditrack.org wrote:
> Author: gli
> Date: 2007-08-16 08:23:36 -0700 (Thu, 16 Aug 2007)
> New Revision: 1893
>
> Modified:
>    src/trunk/DITrack/Command/update.py
> Log:
> catch an exception of failing subversion while updating database
>
> Modified: src/trunk/DITrack/Command/update.py
> ===================================================================
> --- src/trunk/DITrack/Command/update.py	2007-08-16 15:21:06 UTC (rev 1892)
> +++ src/trunk/DITrack/Command/update.py	2007-08-16 15:23:36 UTC (rev 1893)
> @@ -48,5 +48,7 @@
>  
>          db = DITrack.Util.common.open_db(globals, opts, "w")
>          client = DITrack.Client.Client(db)
> -        client.update()
> -
> +        try:
> +            client.update()
> +        except DITrack.DB.Exceptions.SubversionClientError(cmd):
> +            sys.stdout.write("Failed to update database.\n");
>   

I think it should be reported as an error rather than an exception. 
Clients should not be too much aware of the database internals (which is 
implied by catching DB exceptions).

> _______________________________________________
> Commit mailing list
> Commit at lists.ditrack.org
> http://lists.ditrack.org/mailman/listinfo/commit
>   


-- 
Vlad Skvortsov, vss at 73rus.com, http://vss.73rus.com