[ditrack commit] r1894 - in src/trunk/DITrack: . Command DB

[Vlad Skvortsov]

gli at ditrack.org wrote:
> Author: gli
> Date: 2007-08-16 08:49:08 -0700 (Thu, 16 Aug 2007)
> New Revision: 1894
>
> Modified:
>    src/trunk/DITrack/Command/update.py
>    src/trunk/DITrack/DB/Exceptions.py
>    src/trunk/DITrack/DB/WC.py
>    src/trunk/DITrack/SVN.py
> Log:
> fixed errors from previous commits in Exceptions declarations
>
> Modified: src/trunk/DITrack/Command/update.py
> ===================================================================
> --- src/trunk/DITrack/Command/update.py	2007-08-16 15:23:36 UTC (rev 1893)
> +++ src/trunk/DITrack/Command/update.py	2007-08-16 15:49:08 UTC (rev 1894)
> @@ -50,5 +50,5 @@
>          client = DITrack.Client.Client(db)
>          try:
>              client.update()
> -        except DITrack.DB.Exceptions.SubversionClientError(cmd):
> +        except DITrack.DB.Exceptions.SubversionClientError, e:
>              sys.stdout.write("Failed to update database.\n");
>
> Modified: src/trunk/DITrack/DB/Exceptions.py
> ===================================================================
> --- src/trunk/DITrack/DB/Exceptions.py	2007-08-16 15:23:36 UTC (rev 1893)
> +++ src/trunk/DITrack/DB/Exceptions.py	2007-08-16 15:49:08 UTC (rev 1894)
> @@ -85,6 +85,8 @@
>  
>  class SubversionClientError(Exception):
>      message = "Subversion client failed"
> +    def __init__(self,cmd):
> +        self.cmd = cmd
>  
>  #
>  # Not errors, but various conditions.
>
> Modified: src/trunk/DITrack/DB/WC.py
> ===================================================================
> --- src/trunk/DITrack/DB/WC.py	2007-08-16 15:23:36 UTC (rev 1893)
> +++ src/trunk/DITrack/DB/WC.py	2007-08-16 15:49:08 UTC (rev 1894)
> @@ -415,5 +415,5 @@
>          try:
>              self.svn.update(self.path)
>              self.meta['last_update'] = datetime.datetime.today()
> -        except DITrack.SVN.SubversionClientError(cmd):
> -            raise DITrack.DB.Exceptions.SubversionClientError(cmd)
> +        except DITrack.SVN.SubversionClientError, e:
> +            raise DITrack.DB.Exceptions.SubversionClientError(e.cmd)
>   

Why are we reraising the same exception here?

> Modified: src/trunk/DITrack/SVN.py
> ===================================================================
> --- src/trunk/DITrack/SVN.py	2007-08-16 15:23:36 UTC (rev 1893)
> +++ src/trunk/DITrack/SVN.py	2007-08-16 15:49:08 UTC (rev 1894)
> @@ -34,6 +34,8 @@
>  
>  class SubversionClientError(Exception):
>      message = "Subversion client failed"
> +    def __init__(self,cmd):
> +        self.cmd = cmd
>  
>  # XXX: this needs to be moved to the Client class
>  def propget(propname, path, svn_path):
>
> _______________________________________________
> Commit mailing list
> Commit at lists.ditrack.org
> http://lists.ditrack.org/mailman/listinfo/commit
>   


-- 
Vlad Skvortsov, vss at 73rus.com, http://vss.73rus.com