"local_mode" and "no_commits" options for "new" command

Иван Глушков gli.work at gmail.com
Wed Jan 24 23:18:07 PST 2007


On 1/25/07, Vlad Skvortsov <vss at 73rus.com> wrote:
> Иван Глушков wrote:
>
>
> [skipped]
>
> >>
> >> Currently only 2 commands make use of '-l':
> >> 22:27 [vss at claw] ~/ditrack/src/trunk > find . -name "*.py" | xargs grep
> >> -n local_mode
> >> ./DITrack/Command/list.py:62: if opts.var["local_mode"]:
> >> ./DITrack/Command/new.py:110: if opts.var["local_mode"] or
> >> opts.var["no_commits"]:
> >>
> >>
> >> See also i#82.
> >>
> >> My feeling is that '-l' is not appropriate. Now we have the 'status'
> >> command to display local entities, so I'm actually leaning towards
> >> removing '-l' completely... Your opinions?
> >>
> >
> > To my mind, concept "no_commits" is a subset of concept "local_mode".
> > Look at the command list:
> >
> > act, new : "no_commits" is the same as "local_mode"
> > list:  "no_commits" is meaningless, "local_mode" is used.
> >
> > In commands "act","new" we could easily use "local_mode" instead of
> > "no_commits", so may be we should better delete "no_commits"?
>
> We are actually dealing with two separate issues here.
>
> The first is to restrict DITrack to local operations ('local' in a sense
> 'not requiring network access'). As of now, we only need a network
> access when committing.
>
> The second one is to list issues based on their status (local/firm) in
> one single command ('ls').
>
> To me, these two are completely different, that's why I suggest
> decoupling them. Furthermore, I tend to think that '-l' option for 'ls'
> should be reconsidered in a  more general context (and removed for now
> to avoid polluting 0.5 with not-thought-through features).

I still suppose that "list -l" is not the same as "status", but indeed
it should be reconsidered.

Conclusions:
1. We need option for all commands to work in local mode (without
commits). At present it's "-n" = "--no_commits".
2. Two commands do the same job: list local changes to the issue
database. They are "status" and "list -l". So "-l" should be removed.

Something else?


More information about the Dev mailing list