[MQ-PATCH] ditrack: dt-create-db-support-for-null-backend

[Stefan Reichör]

Vlad Skvortsov <vss at 73rus.com> writes:

> Stefan Reichör wrote:
>> Hi!
>>
>> This is my first patch for ditrack ;-)
>>
>> It adds support for the null backend in dt-createdb
>>   
>
> Hey, good start, Stefan! :-)
>
> I've got several comments on the patch.

Thanks for your valuable feedback!

> * Try to separate format changes from functionality changes. I've
> removed the whitespace in r1677.
>
> * The usage note should prominently say if the directory specified
> should exist or will be created by the script.
>
> * Due to indentation in the source, the contents of configuration
> files are also indented (see etc/categories, for example).
>
> * I suggest that the usage note listing the available backends is
> generated based on 'supported_backends' list.

I tried to apply your suggestions.

> * Updating testcases is also highly desirable, though I don't yet have
> a clear picture on how we want to test against various backends. This
> is a topic for another thread though.

I did not take a detailed look at the testcase infrastructure.

ditrack/tests/dt-createdb.tc seems to be the only test.
Could you please remove the trailing spaces in this file also.
I'll try to write the needed tests soon.

Stefan.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ditrack-dt-create-db-support-for-null-backend.patch
Type: text/x-patch
Size: 4916 bytes
Desc: not available
Url : http://lists.ditrack.org/pipermail/dev/attachments/20070709/498d3ad0/attachment.bin