r1527, Template.py from Python 2.5

[Vlad Skvortsov]

Opened i#158 on that.

Vlad Skvortsov wrote:
> Hi!
>
> I'm looking at the changes related to i#123, specifically at the 
> Template.py, added to the repository in r1527.
>
> As far as I can see, it wasn't copied verbatim, since there are two 
> instances of DITrack-specific strings
> "Warning. Unknown variable in filters...". I see several problems with 
> this approach:
>
> 1. The file doesn't have a copyright banner at the top. A permissive 
> license (e.g. Python license in this case) doesn't give us the right to 
> omit the copyrights of original developers.
>
> 2. The file is imported directly into the trunk, which makes maintenance 
> harder in a long run. We've got the top-level directory '/third-party' 
> in the repository, where all third-party sources need to be placed. See 
> http://svnbook.red-bean.com/nightly/en/svn.advanced.vendorbr.html for 
> the detailed explanation of best practices for maintaining third-party 
> sources.
>
> 3. The file was imported and modified in the same commit. Thus it's now 
> impossible to tell what are the changes that we made to the original source.
>
> 4. Originally the imported module serves very general purpose 
> (templating), though now it contains a code which is specific to filters 
> processing in the database configuration. No piece of documentation 
> mentions this, neither it can be inferred from the module placement in 
> the tree and its name.
>
> I thought I needed to bring it to everyone's attention; we are not under 
> any pressure, so let's take our time and make extra effort to keep our 
> codebase in a good shape. This will save us time, energy and nerves 
> later. :-)
>
>   


-- 
Vlad Skvortsov, vss at 73rus.com, http://vss.73rus.com