[ditrack commit] r1498 - in src/trunk/tests: cmd-list/predefined-filter.tc globals/username.tc share/repo

[Ivan Glushkov]

On Tue, 08 May 2007 08:07:46 +0400, Vlad Skvortsov <vss at 73rus.com> wrote:

> Ivan Glushkov wrote:
>> Hi.
>>> Is the only difference between a.gz and filters.gz that the latter has
>>> more custom filters added? Can we add those to a.gz and remove  
>>> filters.gz?
>> I added two filters:
>>
>> sample-filter2: Status=open,Owned-by=$DT:USER
>> sample-filter3: Status=open,Owned-by=$DT:UNDEFINED_VAR
>>
>> The second filter tests warning messages:
>> $ cat ls.err.expected
>> Warning. Unknown variable in filters: '$DT:UNDEFINED_VAR'
>>
>> I thought that this warning (that appear everywhere) would disturb us,
>> so i created new archive.
>
> I think it's fine as long as it doesn't generate false positives. We  
> rarely look at the test output manually and when we do, we are enough  
> "in the context" to parse it out.
>


I made it default archive and all tests that used stderr failed:
$ grep FAIL LOG
./cmd-act/invalid-issues.tc: FAIL
./cmd-act/local-mode.tc: FAIL
./cmd-cat/invalid-entity.tc: FAIL
./cmd-remove.tc: FAIL
./i98/act.tc: FAIL

I think that it's a bad idea to use default archive that always send
some warnings on stderr. In this case we should parse output in _all_
testcases (grep -v "DT:UNDEFINED_VAR") or we should define some
environment variables.
I'll better have two distinct archives.