[ditrack commit] r2341 - src/trunk/tests/dttest

[Vlad Skvortsov]

gli at ditrack.org wrote:
> Author: gli
> Date: 2007-11-12 07:54:01 -0800 (Mon, 12 Nov 2007)
> New Revision: 2341
>
> Modified:
>    src/trunk/tests/dttest/dttest.py
> Log:
> new function last_rev(). It would return last revision of database.
>
> Modified: src/trunk/tests/dttest/dttest.py
> ===================================================================
> --- src/trunk/tests/dttest/dttest.py	2007-11-12 14:57:35 UTC (rev 2340)
> +++ src/trunk/tests/dttest/dttest.py	2007-11-12 15:54:01 UTC (rev 2341)
> @@ -379,6 +379,15 @@
>          else:
>              return issue_path
>  
> +    def last_rev(self):
> +        """
> +        Returns the revision of the database
> +        """
>   

Which revision? The current or last changed one? The right thing to use 
here is actually 'svn info', since 'svn log' might not always return the 
HEAD revision in its output (e.g. right after "commit" before any 
"update" took place).


> +        svnlog = "svn_log.out"
> +        self.svn_log_last(outfile=svnlog)
> +        last_rev = int(open(svnlog, "r").readlines()[1].split()[0][1:])
> +        return last_rev
> +
>      def lma_entity(self, id):
>          lma = shelve.open(self.path["lma"])
>          entity = lma[id]
> @@ -533,6 +542,9 @@
>  
>          rev_arg = ""
>          if rev is not None:
> +            if rev < 0:
> +                rev = self.last_rev() + rev
> +                assert (rev > 0)
>   

Why not documented? Also, assert makes() more sense before updating 
'rev' from a user standpoint. Braces are unnecessary, per our style.

-- 
Vlad Skvortsov, vss at 73rus.com, http://vss.73rus.com